Commit graph

292 commits

Author SHA1 Message Date
sluicebox
817d9dc80a SCI: Fix LB2CD Yvette/Tut murderless message
Fixes wrong message in cd versions, bug #10724
2018-10-08 02:42:04 +03:00
sluicebox
0e91fe623b SCI: Script patch for LB2 act 4 init, bug #10716
Fixes a lockup in the original game
2018-10-02 20:37:42 +03:00
sluicebox
12af1929ef SCI: Script patch for LB2 armor inset, bug #10709
Fixes missing messages in floppy version
2018-09-29 02:21:17 -04:00
sluicebox
875ce8101c SCI: Script patch for LB2 desk lamp, bug #10706
Fixes a broken message in floppy version
2018-09-21 22:19:57 +03:00
sluicebox
2373fd8152 SCI: Script patch for LB2 crate room bug #10701
Fixes a lockup in the original game
2018-09-16 18:50:07 +03:00
Filippos Karapetis
4913cd4eb2 SCI32: Add more workarounds for Hoyle Classic Games
This fixes issues with Bridge and Backgammon. Now, Hoyle 5 and its
variants should be in a very good state for testing
2018-09-04 23:36:20 +03:00
Filippos Karapetis
cc09b66671 SCI32: Fix pathfinding issues at the inn in QFG4 2018-09-01 14:40:58 +03:00
Filippos Karapetis
dd7c000e44 SCI32: Hide the unavailable games in the Hoyle 5 derived collections
The derived collections include Hoyle Children's Collection and Hoyle
Bridge. Each collection includes a subset of the games in the full
version, Hoyle Classic Games
2018-08-30 23:51:01 +03:00
Filippos Karapetis
414d0277d0 SCI: Fix compilation 2018-08-25 12:57:01 +03:00
Filippos Karapetis
d597fbc5e3 SCI32: Fix the walk region in Cazanoux's house in GK1
Fixes bug #9770
2018-08-25 12:39:14 +03:00
Willem Jan Palenstijn
0f98a60d35 SCI: Sabotage qfg1vga's speed test
This ensures the detected speed will end up at the highest level. This
improves the detail in Yorick's room (96), and slightly changes the
timing in other rooms.

Fixes bug #10296.
2018-02-01 20:08:20 +01:00
David Fioramonti
9518fd7210 SCI32: Fix PQ4 Barbie shoe points patch selector
The original script patch had the correct literal value but the
wrong selector name in the comment for the literal value, so when
it was converted to use a selector lookup in
c5dce17b1f, the patch broke because
the wrong selector name was used.

Fixes Trac#10392. Closes gh-1107.
2018-01-16 21:32:38 -06:00
David Fioramonti
ce052fbef4 SCI32: Fix cursor color when quitting for phant1
When quitting the game at the main menu and hitting no
or quitting the game while playing the cursor color
over the buttons will be tan the first time rather
than red. This fix makes it so it will be red.

This was done by removing a check in HotSpot::doit()
which checks the global193 value. Removing this check
fixes the problem.

Fixes Trac#9977.

Thanks snover and wjp for your help.
2017-10-16 19:37:36 -05:00
Colin Snover
bb02d730b4 SCI32: Fix crash restoring save from endgame of RAMA
Fixes Trac#10263.
2017-10-08 19:25:54 -05:00
Martin Kiewitz
bd94bbc3e3 SCI: Add QfG4 script patch to fix sliding down slope bug #9801
It's quite difficult to patch. I hope this finally solved it.
2017-10-09 01:58:16 +02:00
Martin Kiewitz
83436e685f SCI: Improve Larry 1 Spanish script patch
So that it also works even when the patch files are missing.
2017-10-07 19:06:16 +02:00
Martin Kiewitz
eb1f9030a7 SCI: Add script patch for Larry 1 Spanish bug #10240
Fixes buying an apple from man wearing a barrel, who walks
around in front of the casino.
2017-10-07 18:56:29 +02:00
Colin Snover
8c9276e75a SCI32: Clean up script patch comments 2017-10-06 22:56:25 -05:00
Colin Snover
90036a56f8 SCI32: Speed up memory check counter in lighthouse in Lighthouse 2017-10-04 00:27:18 -05:00
Colin Snover
08f501117b SCI32: Give more specific game version numbers 2017-10-04 00:27:18 -05:00
Colin Snover
3cdf26b355 SCI32: Fix bad text rendering in RAMA
In SCI3, Sierra removed the ability of the main renderer to
automatically scale CelObjs with different source resolutions.
Instead, in SCI3, all CelObjs are treated as having the same
resolution as the screen (i.e. 640x480).

In all SCI3 games other than RAMA, keeping the code paths for
resolution-dependent scaling is not a problem because all the
assets and game code are correctly designed to use the same
640x480 resolution throughout. RAMA, on the other hand, was
written with the text subsystem set to a resolution of 630x450
(Phant1's screen resolution), and in SSCI, resolution-dependent
scaling code was not removed from the *text* subsystem. As a
result, RAMA's game scripts rely on the slightly larger scaled
dimensions coming out of the text system when determining the size
of screen items for rendering, and then also rely on the main
renderer ignoring the 630x450 resolution baked into the bitmaps
generated by the text subsystem when drawing them to the screen.
2017-09-29 19:56:24 -05:00
Martin Kiewitz
6f163b9325 SCI: Add script patch for QfG2 Jackalmen Oops - bug #10218
Was a game bug, finally fixed.
This was a combined effort of wjp and myself. Thanks to wjp.
We both don't own QfG2 1.000 atm, so we could not try it for that
version.
2017-09-28 23:51:35 +02:00
Colin Snover
f570e4b351 SCI32: Disable change directory button in original save/load in RAMA 2017-09-28 14:58:18 -05:00
Martin Kiewitz
26183f7289 SCI: Add SQ4CD script patch to add audio for universal remote control
for Hk So Good store catalog.
Implements enhancement #10227
2017-09-24 19:00:12 +02:00
Colin Snover
d2364cb9bb SCI32: Fix bad data cube text priority calculation in RAMA 2017-09-23 20:57:04 -05:00
Colin Snover
6972c9ae46 SCI32: Fix bad default text scaling in RAMA 2017-09-23 20:57:02 -05:00
Colin Snover
b038432952 SCI32: Support RAMA's custom save games through kFileIO 2017-09-23 20:56:48 -05:00
Colin Snover
52d9d04919 SCI32: Fix inconsistent patch instruction comments
I missed these lines when going through things earlier.
2017-09-19 20:00:28 -05:00
Martin Kiewitz
4a9098d083 SCI32: Heap patch for Phantasmagoria 2 to fix DocuStore placements
This fixes placement of "File", "Note", "From" and "Subject"
content.
See bug #10034
2017-09-17 19:13:03 +02:00
Martin Kiewitz
294503f516 SCI32: GK1CD: script for vine swing issue bug #9820
Gabriel's "I can't believe I'm doing this..." line was cut off.
This script patch stops that from happening.
2017-09-17 14:43:27 +02:00
Martin Kiewitz
1d018d65c8 SCI32: Clean-up pass on GK1,GK2,KQ7,PQ4,QfG4,Torin script patches
comments only
2017-09-17 01:51:50 +02:00
Colin Snover
a9316560ab SCI: Remove unused selector from script patcher selectors list 2017-09-16 16:33:09 -05:00
Colin Snover
e400f1aec2 SCI32: Clean-up pass on Torin script patches
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
2017-09-16 16:33:09 -05:00
Colin Snover
d1c43b24ea SCI32: Clean-up pass on GK1 script patches
* Make alignment of operation comments consistent
* Make patch descriptions consistent
2017-09-16 16:33:09 -05:00
Colin Snover
4e6fa4d690 SCI32: Clean-up pass on Shivers script patches
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
* Wrap comments at 80 columns
* Rewrite comments for clarity and brevity
* Make identifier suffixes, patch descriptions, and patch table
  ordering consistent
2017-09-16 16:33:09 -05:00
Colin Snover
4dcf88ef4f SCI32: Clean-up pass on Rama script patches
* Make alignment of operation comments consistent
2017-09-16 16:33:09 -05:00
Colin Snover
3b7e610364 SCI32: Clean-up pass on QFG4 script patches
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
* Make identifier suffixes and patch descriptions consistent
2017-09-16 16:33:09 -05:00
Colin Snover
c5dce17b1f SCI32: Clean-up pass on PQ4 script patches
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
* Convert word-size numeric literals to SIG_UINT16/PATCH_UINT16
* Wrap comments at 80 columns
* Rewrite comments for clarity and brevity
* Make alignment of operation comments consistent
* Make identifier suffixes, patch descriptions, and patch table
  ordering consistent
2017-09-16 16:33:08 -05:00
Colin Snover
34683f1725 SCI32: Clean-up pass on PQ:SWAT script patches
* Make patch descriptions consistent
2017-09-16 16:33:08 -05:00
Colin Snover
b9600bf466 SCI32: Clean-up pass on Phant2 script patches
* Minor clarity fixes to comments
* Make patch descriptions and patch table ordering consistent
2017-09-16 16:33:08 -05:00
Colin Snover
6fc09ae7c9 SCI32: Clean-up pass on Phant1 script patches
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
* Make identifier suffixes, patch descriptions, and patch table
  ordering consistent
2017-09-16 16:33:08 -05:00
Colin Snover
bfb87389f7 SCI32: Clean-up pass on MGDX script patches
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
* Fix a patch to use jmp instead of waste bytes
* Make identifier suffixes and patch descriptions consistent
2017-09-16 16:33:08 -05:00
Colin Snover
f7d20dc2e7 SCI32: Clean-up pass on LSL7 script patches
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
* Convert word-size numeric literals to SIG_UINT16/PATCH_UINT16
* Wrap comments at 80 columns
* Rewrite comments for clarity and brevity
* Make alignment of operation comments consistent
* Make identifier suffixes and patch descriptions consistent
2017-09-16 16:33:08 -05:00
Colin Snover
ea33f26d05 SCI32: Clean-up pass on LSL6hires script patches
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
* Make identifier suffixes and patch descriptions consistent
2017-09-16 16:33:07 -05:00
Colin Snover
59fe526b16 SCI32: Clean-up pass on Lighthouse script patches
* Make patch descriptions consistent
2017-09-16 16:33:07 -05:00
Colin Snover
08291cca3c SCI32: Clean-up pass on KQ7 script patches
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
* Convert word-size numeric literals to SIG_UINT16/PATCH_UINT16
* Wrap comments at 80 columns
* Rewrite comments for clarity and brevity
* Make alignment of operation comments consistent
* Make identifier suffixes and patch descriptions consistent
2017-09-16 16:33:07 -05:00
Colin Snover
bbcee7e6a1 SCI32: Clean-up pass on GK2 script patches
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
* Make alignment of operation comments consistent
* Make patch descriptions consistent
2017-09-16 16:33:06 -05:00
Colin Snover
96d4bb603d SCI32: Clean-up pass on GK1 script patches
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
* Convert word-size numeric literals to SIG_UINT16/PATCH_UINT16
* Wrap comments at 80 columns
* Rewrite comments for clarity and brevity
* Make alignment of operation comments consistent
* Make identifier suffixes, patch descriptions, and patch table
  ordering consistent
* Remove no-longer-needed script patch for day 10 room 808, which
  has been fixed using a different, generic mechanism since commit
  e8c429832f
2017-09-16 16:33:06 -05:00
Martin Kiewitz
bbbbfb64dc SCI32: Add script patch for PQ4CD for dual mode (text+speech)
This makes the game menu able to handle a 3rd state, so that the
game shows text but also play speech at the same time.

We need to inject our own view for the new button to really show
up. I'm not that experienced with the SCI32 graphics code, which
is why I prefer snover to do this part.
Right now it will show the button with text selected 2 times in
a row. The first "text" button is the dual mode / "both" state.

Anyway, thanks to snover for notifying me of this game needing
dual mode patched in and also for some help.
2017-09-16 19:58:40 +02:00
David Fioramonti
817c9e77aa SCI32: Fix bad play call in Shivers room 23090
This fixes a bad play call by replacing it with a fade call.

The newRoom function In script rm23v090 (room 23090) was
calling a play function with 5 arguments, but the play
function only takes 4 arguments. Since it looks like a fade
call it has been replaced with that.

Fixes Trac#10200.

snover helped.
2017-09-15 23:44:13 -05:00