Commit graph

9 commits

Author SHA1 Message Date
Strangerke
c0de8dd04d LILLIPUT: Fix unsafe read of string reported by coverity 2018-04-20 06:55:10 +02:00
Adrian Frühwirth
00e59a3122 ALL: Load savegame thumbnail only when necessary
This commit introduces the following changes:

1. Graphics::loadThumbnail()

   Now returns a boolean and takes a new argument skipThumbnail which
   defaults to false. In case of true, loadThumbnail() reads past the
   thumbnail data in the input stream instead of actually loading the
   thumbnail. This simplifies savegame handling where, up until now,
   many engines always read the whole savegame metadata (including
   the thumbnail) and then threw away the thumbnail when not needed
   (which is in almost all cases, the most common exception being
   MetaEngine::querySaveMetaInfos() which is responsible for loading
   savegame metadata for displaying it in the GUI launcher.

2. readSavegameHeader()

   Engines which already implement such a method (name varies) now take
   a new argument skipThumbnail (default: true) which is passed
   through to loadThumbnail(). This means that the default case for
   readSavegameHeader() is now _not_ loading the thumbnail from a
   savegame and just reading past it. In those cases, e.g.
   querySaveMetaInfos(), where we actually are interested in loading
   the thumbnail readSavegameHeader() needs to explicitely be called
   with skipThumbnail == false.

   Engines whose readSavegameHeader() (name varies) already takes an
   argument loadThumbnail have been adapted to have a similar
   prototype and semantics.
   I.e. readSaveHeader(in, loadThumbnail, header) now is
   readSaveHeader(in, header, skipThumbnail).

3. Error handling

   Engines which previously did not check the return value of
   readSavegameHeader() (name varies) now do so ensuring that possibly
   broken savegames (be it a broken thumbnail or something else) don't
   make it into the GUI launcher list in the first place.
2018-04-07 09:26:20 +02:00
Joseph-Eugene Winzer
157e69b8b1 LILLIPUT: Sorts SaveStateList instead of file names
This ensures that the save files are sorted numerically instead of
'hoping' for it.
2018-03-28 17:36:57 +02:00
Joseph-Eugene Winzer
132fa2fdab LILLIPUT: Updates savefile pattern for numeric wildcard 2018-03-28 17:36:57 +02:00
Strangerke
c8495aa457 LILLIPUT: Fix a couple of remaining 'Robin' engine strings 2018-03-28 17:36:57 +02:00
Joseph-Eugene Winzer
de7c3d345e LILLIPUT: Marks game as unstable 2018-03-28 17:36:57 +02:00
Strangerke
e1bc0469de LILLIPUT: Janitorial: fix code formatting 2018-03-28 17:36:57 +02:00
Strangerke
38b7961bcb LILLIPUT: Add detection for French, German and Italian versions 2018-03-28 17:36:57 +02:00
Strangerke
5757ffaff0 LILLIPUT: Add skeletton 2018-03-28 17:36:57 +02:00