003853d665
Gtk sets the locale when it's set up to make parts of the UI localized. We set it properly before displaying the dialog and reset to "C" afterwards to avoid portability issues in number parsing functions. Fixes #14196 Thanks to @rootfather and @elasota for the investigation.
128 lines
4 KiB
C++
128 lines
4 KiB
C++
/* ScummVM - Graphic Adventure Engine
|
|
*
|
|
* ScummVM is the legal property of its developers, whose names
|
|
* are too numerous to list here. Please refer to the COPYRIGHT
|
|
* file distributed with this source distribution.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#define FORBIDDEN_SYMBOL_EXCEPTION_FILE
|
|
#define FORBIDDEN_SYMBOL_EXCEPTION_unistd_h
|
|
#define FORBIDDEN_SYMBOL_EXCEPTION_time_h
|
|
#define FORBIDDEN_SYMBOL_EXCEPTION_setlocale
|
|
#include "common/scummsys.h"
|
|
|
|
#if defined(POSIX) && defined(USE_SYSDIALOGS) && defined(USE_GTK)
|
|
|
|
#include "backends/dialogs/gtk/gtk-dialogs.h"
|
|
|
|
#include "common/config-manager.h"
|
|
#include "common/events.h"
|
|
#include "common/translation.h"
|
|
|
|
#include <locale.h>
|
|
#include <gtk/gtk.h>
|
|
|
|
// TODO: Move this into the class? Probably possible, but I've been told that
|
|
// this might not necessarily work properly with all compilers.
|
|
|
|
static gboolean _inDialog;
|
|
static uint32 _lastUpdateTick = 0;
|
|
|
|
static gboolean idleCallback(gpointer data) {
|
|
uint32 currentTick = g_system->getMillis();
|
|
if (g_system->getMillis() - _lastUpdateTick > 10) {
|
|
Common::Event dummy;
|
|
while (g_system->getEventManager()->pollEvent(dummy)) {}
|
|
g_system->updateScreen();
|
|
_lastUpdateTick = currentTick;
|
|
}
|
|
return _inDialog;
|
|
}
|
|
|
|
Common::DialogManager::DialogResult GtkDialogManager::showFileBrowser(const Common::U32String &title, Common::FSNode &choice, bool isDirBrowser) {
|
|
if (!gtk_init_check(NULL, NULL))
|
|
return kDialogError;
|
|
|
|
DialogResult result = kDialogCancel;
|
|
|
|
// Convert labels to UTF-8
|
|
Common::String utf8Title = title.encode();
|
|
Common::String utf8Choose = _("Choose").encode();
|
|
Common::String utf8Cancel = _("Cancel").encode();
|
|
|
|
GtkFileChooserAction action = GTK_FILE_CHOOSER_ACTION_OPEN;
|
|
if (isDirBrowser) {
|
|
action = GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER;
|
|
}
|
|
|
|
// Set locale to environment one to let user have its localized folders in the browser
|
|
setlocale(LC_ALL, "");
|
|
|
|
#if GTK_CHECK_VERSION(3,20,0)
|
|
GtkFileChooserNative *native = gtk_file_chooser_native_new(utf8Title.c_str(), NULL, action, utf8Choose.c_str(), utf8Cancel.c_str());
|
|
GtkFileChooser *chooser = GTK_FILE_CHOOSER(native);
|
|
#else
|
|
GtkWidget *dialog = gtk_file_chooser_dialog_new(utf8Title.c_str(), NULL, action, utf8Choose.c_str(), GTK_RESPONSE_ACCEPT, utf8Cancel.c_str(), GTK_RESPONSE_CANCEL, NULL);
|
|
GtkFileChooser *chooser = GTK_FILE_CHOOSER(dialog);
|
|
#endif
|
|
|
|
// Customize dialog
|
|
gtk_file_chooser_set_show_hidden(chooser, ConfMan.getBool("gui_browser_show_hidden", Common::ConfigManager::kApplicationDomain));
|
|
if (ConfMan.hasKey("browser_lastpath")) {
|
|
gtk_file_chooser_set_current_folder(chooser, ConfMan.get("browser_lastpath").c_str());
|
|
}
|
|
|
|
// Show dialog
|
|
beginDialog();
|
|
|
|
_inDialog = TRUE;
|
|
g_idle_add(idleCallback, NULL);
|
|
|
|
#if GTK_CHECK_VERSION(3,20,0)
|
|
int res = gtk_native_dialog_run(GTK_NATIVE_DIALOG(native));
|
|
#else
|
|
int res = gtk_dialog_run(GTK_DIALOG(dialog));
|
|
#endif
|
|
if (res == GTK_RESPONSE_ACCEPT) {
|
|
// Get the selection from the user
|
|
char *path = gtk_file_chooser_get_filename(chooser);
|
|
choice = Common::FSNode(path);
|
|
ConfMan.set("browser_lastpath", path);
|
|
result = kDialogOk;
|
|
g_free(path);
|
|
}
|
|
|
|
_inDialog = FALSE;
|
|
|
|
// Restore default C locale to prevent issues with
|
|
// portability of sscanf(), atof(), etc.
|
|
// See bugs #6434 and #14196
|
|
setlocale(LC_ALL, "C");
|
|
|
|
#if GTK_CHECK_VERSION(3,20,0)
|
|
g_object_unref(native);
|
|
#else
|
|
gtk_widget_destroy(dialog);
|
|
#endif
|
|
|
|
while (gtk_events_pending())
|
|
gtk_main_iteration();
|
|
endDialog();
|
|
return result;
|
|
}
|
|
|
|
#endif
|