==3124361== Invalid write of size 8 ==3124361== at 0x483F803: memmove (vg_replace_strmem.c:1270) ==3124361== by 0x4DBF61: SurfaceSdlGraphicsManager::grabOverlay(void*, int) const (surfacesdl-graphics.cpp:1753) ==3124361== by 0x482051: ModularGraphicsBackend::grabOverlay(void*, int) (modular-backend.cpp:215) ==3124361== by 0x434EE1: GUI::ThemeEngine::clearAll() (ThemeEngine.cpp:376) ==3124361== by 0x40128E: GUI::EventRecorder::preDrawOverlayGui() (EventRecorder.cpp:558) ==3124361== by 0x481DB2: ModularGraphicsBackend::updateScreen() (modular-backend.cpp:173) ==3124361== by 0x559967: Graphics::Screen::updateScreen() (screen.cpp:62) ==3124361== by 0x55991C: Graphics::Screen::update() (screen.cpp:56) ==3124361== by 0x38AFC7: TwinE::TwineScreen::update() (twine.cpp:126) ==3124361== by 0x3B8759: TwinE::Screens::adjustPalette(unsigned char, unsigned char, unsigned char, unsigned int const*, int) (screens.cpp:150) ==3124361== by 0x3B8A89: TwinE::Screens::fadeToPal(unsigned int const*) (screens.cpp:207) ==3124361== by 0x3B8403: TwinE::Screens::loadImage(int, int, bool) (screens.cpp:80) ==3124361== Address 0x31453050 is 16 bytes after a block of size 512,000 alloc'd ==3124361== at 0x483AB65: calloc (vg_replace_malloc.c:760) ==3124361== by 0x55B38C: Graphics::Surface::create(unsigned short, unsigned short, Graphics::PixelFormat const&) (surface.cpp:75) ==3124361== by 0x551111: Graphics::ManagedSurface::create(unsigned short, unsigned short, Graphics::PixelFormat const&) (managed_surface.cpp:153) ==3124361== by 0x4352D5: GUI::ThemeEngine::setGraphicsMode(GUI::ThemeEngine::GraphicsMode) (ThemeEngine.cpp:453) ==3124361== by 0x434A52: GUI::ThemeEngine::init() (ThemeEngine.cpp:324) ==3124361== by 0x43501B: GUI::ThemeEngine::refresh() (ThemeEngine.cpp:394) ==3124361== by 0x405780: GUI::GuiManager::screenChange() (gui-manager.cpp:603) ==3124361== by 0x405C6B: GUI::GuiManager::processEvent(Common::Event const&, GUI::Dialog*) (gui-manager.cpp:677) ==3124361== by 0x404EBA: GUI::GuiManager::runLoop() (gui-manager.cpp:429) ==3124361== by 0x3FD847: GUI::Dialog::runModal() (dialog.cpp:77) ==3124361== by 0x36D747: launcherDialog() (main.cpp:106) ==3124361== by 0x36FF92: scummvm_main (main.cpp:552) It looks like the _videoMode.overlayHeight in SurfaceSdlGraphicsManager::grabOverlay and ThemeEngine::_backBuffer::h are somehow out of sync after starting the game in a different resolution as the gui was started with. So the overlayHeight is updated - but the backbuffer (Surface) is not resized. This is with event recorder being active - right after starting the game and switching the resolution.
172 lines
5.8 KiB
C++
172 lines
5.8 KiB
C++
/* ResidualVM - Graphic Adventure Engine
|
|
*
|
|
* ResidualVM is the legal property of its developers, whose names
|
|
* are too numerous to list here. Please refer to the COPYRIGHT
|
|
* file distributed with this source distribution.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef ANDROID_GRAPHICS_H
|
|
#define ANDROID_GRAPHICS_H
|
|
|
|
#include "common/scummsys.h"
|
|
#include "backends/graphics/graphics.h"
|
|
|
|
class AndroidGraphicsManager : public GraphicsManager {
|
|
public:
|
|
AndroidGraphicsManager();
|
|
virtual ~AndroidGraphicsManager();
|
|
|
|
void initSurface();
|
|
void deinitSurface();
|
|
|
|
void updateScreen() override;
|
|
|
|
void displayMessageOnOSD(const Common::U32String &msg);
|
|
|
|
bool notifyMousePosition(Common::Point &mouse);
|
|
Common::Point getMousePosition() { return Common::Point(_cursorX, _cursorY); }
|
|
void setMousePosition(int x, int y) { _cursorX = x; _cursorY = y; }
|
|
|
|
virtual void beginGFXTransaction() {}
|
|
virtual OSystem::TransactionError endGFXTransaction() { return OSystem::kTransactionSuccess; }
|
|
|
|
virtual const OSystem::GraphicsMode *getSupportedGraphicsModes() const override;
|
|
virtual int getDefaultGraphicsMode() const override;
|
|
virtual bool setGraphicsMode(int mode, uint flags = OSystem::kGfxModeNoFlags) override;
|
|
virtual int getGraphicsMode() const override;
|
|
|
|
virtual bool hasFeature(OSystem::Feature f) const override;
|
|
virtual void setFeatureState(OSystem::Feature f, bool enable) override;
|
|
virtual bool getFeatureState(OSystem::Feature f) const override;
|
|
|
|
virtual void showOverlay() override;
|
|
virtual void hideOverlay() override;
|
|
virtual void clearOverlay() override;
|
|
virtual void grabOverlay(Graphics::Surface &surface) const override;
|
|
virtual void copyRectToOverlay(const void *buf, int pitch,
|
|
int x, int y, int w, int h) override;
|
|
virtual int16 getOverlayHeight() const override;
|
|
virtual int16 getOverlayWidth() const override;
|
|
virtual Graphics::PixelFormat getOverlayFormat() const override;
|
|
virtual bool isOverlayVisible() const override { return _show_overlay; }
|
|
|
|
virtual int16 getHeight() const override;
|
|
virtual int16 getWidth() const override;
|
|
|
|
// PaletteManager API
|
|
virtual void setPalette(const byte *colors, uint start, uint num) override;
|
|
virtual void grabPalette(byte *colors, uint start, uint num) const override;
|
|
virtual void copyRectToScreen(const void *buf, int pitch, int x, int y,
|
|
int w, int h) override;
|
|
virtual Graphics::Surface *lockScreen() override;
|
|
virtual void unlockScreen() override;
|
|
virtual void fillScreen(uint32 col);
|
|
|
|
virtual void setShakePos(int shakeXOffset, int shakeYOffset) {};
|
|
virtual void setFocusRectangle(const Common::Rect& rect) {}
|
|
virtual void clearFocusRectangle() {}
|
|
|
|
virtual void initSize(uint width, uint height,
|
|
const Graphics::PixelFormat *format) override;
|
|
virtual int getScreenChangeID() const override;
|
|
|
|
virtual bool showMouse(bool visible) override;
|
|
virtual void warpMouse(int x, int y) override;
|
|
virtual bool lockMouse(bool lock) override;
|
|
virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspotX,
|
|
int hotspotY, uint32 keycolor,
|
|
bool dontScale,
|
|
const Graphics::PixelFormat *format) override;
|
|
virtual void setCursorPalette(const byte *colors, uint start, uint num) override;
|
|
|
|
|
|
void setupScreen(uint screenW, uint screenH, bool fullscreen, bool accel3d);
|
|
|
|
void setupScreen(uint screenW, uint screenH, bool fullscreen, bool accel3d, bool isGame);
|
|
void updateScreenRect();
|
|
const GLESBaseTexture *getActiveTexture() const;
|
|
void clipMouse(Common::Point &p) const;
|
|
|
|
#ifdef USE_RGB_COLOR
|
|
virtual Graphics::PixelFormat getScreenFormat() const override;
|
|
virtual Common::List<Graphics::PixelFormat> getSupportedFormats() const override;
|
|
#endif
|
|
|
|
protected:
|
|
void setSystemMousePosition(int x, int y) {}
|
|
|
|
bool loadVideoMode(uint requestedWidth, uint requestedHeight, const Graphics::PixelFormat &format);
|
|
|
|
void refreshScreen();
|
|
|
|
void *getProcAddress(const char *name) const;
|
|
|
|
private:
|
|
void setCursorPaletteInternal(const byte *colors, uint start, uint num);
|
|
void disableCursorPalette();
|
|
void initOverlay();
|
|
void initViewport();
|
|
void updateEventScale();
|
|
void initSizeIntern(uint width, uint height, const Graphics::PixelFormat *format);
|
|
|
|
enum FixupType {
|
|
kClear = 0, // glClear
|
|
kClearSwap, // glClear + swapBuffers
|
|
kClearUpdate // glClear + updateScreen
|
|
};
|
|
|
|
void clearScreen(FixupType type, byte count = 1);
|
|
#ifdef USE_RGB_COLOR
|
|
void initTexture(GLESBaseTexture **texture, uint width, uint height,
|
|
const Graphics::PixelFormat *format);
|
|
#endif
|
|
|
|
private:
|
|
int _screenChangeID;
|
|
int _graphicsMode;
|
|
bool _opengl;
|
|
bool _fullscreen;
|
|
bool _ar_correction;
|
|
bool _force_redraw;
|
|
|
|
// Game layer
|
|
GLESBaseTexture *_game_texture;
|
|
Graphics::PixelBuffer _game_pbuf;
|
|
OpenGL::FrameBuffer *_frame_buffer;
|
|
|
|
/**
|
|
* The position of the mouse cursor, in window coordinates.
|
|
*/
|
|
int _cursorX, _cursorY;
|
|
|
|
// Overlay layer
|
|
GLES4444Texture *_overlay_texture;
|
|
bool _show_overlay;
|
|
|
|
// Mouse layer
|
|
GLESBaseTexture *_mouse_texture;
|
|
GLESBaseTexture *_mouse_texture_palette;
|
|
GLES5551Texture *_mouse_texture_rgb;
|
|
Common::Point _mouse_hotspot;
|
|
uint32 _mouse_keycolor;
|
|
int _mouse_targetscale;
|
|
bool _show_mouse;
|
|
bool _use_mouse_palette;
|
|
};
|
|
|
|
#endif
|