thirdparty/util-linux
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

docs: add note about GitHub PR

Browse source 
Signed-off-by: Karel Zak <kzak@redhat.com>
This commit is contained in:
Karel Zak 2021-10-14 10:22:14 +02:00
parent 90e0342bbf
commit 9c2b43b19f
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Documentation/howto-pull-request.txt
View file

@ -128,7 +128,17 @@ git rebase -i master
# change something # change something
git push -f yourgit textual:textual git push -f yourgit textual:textual
4. Assuming the changes look good send them to mail list. Yes, the all 4. You have two ways how to send your pull request:
4.1 Github pull request
This is recommended way for your small and trivial changes, or for
work-in-progress projects (rewrites, new commands, etc.). All you
need is to press "pull request" button on GitHub.
4.2. Send your work to the mailing list
Assuming the changes look good send them to mail list. Yes, the all
of them! Sending pull request with github is not visible for project of them! Sending pull request with github is not visible for project
contributors, and they will not have change to review your changes. contributors, and they will not have change to review your changes.