Commit graph

384 commits

Author SHA1 Message Date
Filippos Karapetis
6ade0e1457 SCI: Expand an uninitialized read workaround for SQ6 2012-07-25 02:29:57 +03:00
Filippos Karapetis
44935117f4 SCI: Fix a workaround for an uninitialized variable in SQ4CD
This makes sure that the workaround works for subclassed objects as well,
such as "theProfessor" talker. Fixes bug #3539350 - "SCI: SQ4 CD -
Crash in sewer when text and speech enabled"
2012-07-02 12:49:08 +03:00
Filippos Karapetis
e2613d2242 SCI: Add a workaround for the French version of Torin's Passage
Thanks to LePhilousophe for playing and providing the workaround
2012-06-13 12:27:00 +03:00
Filippos Karapetis
5a8a28bb22 SCI: Add a workaround for a hack used in the NRS script patches for QFG3
The patched script 33 in the NRS patch attempts to perform kAbs() on an
object. Return a dummy value instead. Fixes bugs #3528416 and #3528542
2012-05-22 10:50:39 +03:00
Filippos Karapetis
6f9e49faeb SCI: Add another workaround for the map scene in TMM
Thanks to TMM for details on reproducing this
2012-05-20 20:16:11 +03:00
Filippos Karapetis
793dcda650 SCI: Bugfix for the GetAngle workarounds
Return a fake value instead of leaving random values in the accumulator
2012-04-04 07:41:44 +03:00
D G Turner
639c54a306 SCI: Add workaround for SQ1SCI to fix engine abort in bug #3513765.
This occurs while Roger is trying to move around the Pilot Droid in
Ulence Flats.
2012-04-01 01:50:08 +01:00
Filippos Karapetis
95fb73bcc5 SCI: Change the fix for the SQ1 PAvoider call to apply in all rooms again
This bad call can be made in all rooms in Ulence Flats, after getting the
Pilot Droid. Properly fixes script bug #3513207
2012-04-01 01:32:03 +03:00
Filippos Karapetis
21e8f2f441 SCI: Fix workaround for bug #3513207
The associated call contains too few parameters, thus it shouldn't be made
at all
2012-03-31 05:53:29 +03:00
D G Turner
5bbfd008b6 SCI: Minor formatting fix to workarounds table. 2012-03-31 02:25:20 +01:00
D G Turner
834e9184e5 SCI: Add workaround for SQ1SCI to fix engine abort in bug #3513207.
This occurs while Roger is trying to move around the Pilot Droid in
various narrow cases.
2012-03-31 01:39:03 +01:00
Filippos Karapetis
5bb473df88 SCI: Update a workaround for the demo of QFG4 to make it work again 2012-01-16 19:19:09 +02:00
Filippos Karapetis
5ba50c69b1 SCI: Changed the kUnload workaround for the LB2 demo to apply to all scenes 2011-10-19 23:52:52 +03:00
Heather Douglass
c5e6cdea55 SCI: 3 Uninitialized read workarounds for Shivers 2011-10-12 02:47:26 +03:00
Filippos Karapetis
b4a23a709d SCI2+: Added a workaround for an uninitialized temp in PQ4 2011-10-09 03:04:54 +03:00
Filippos Karapetis
b807041ad2 SCI: Ignore invalid pointers if the kernel function signature specifies it
SCI scripts can send stale pointers to kernel functions (e.g. after
loading a saved game). This is normal in some cases (such as kDisplay
and kGraphRestoreBox), and their signatures are set to allow invalid
pointers.
Thus, in such cases, allow invalid pointers, as the kernel functions
will handle them themselves. Fixes bug #3412002, and properly fixes bugs
#3389579, #3292251, #3308087 and #3056811. Removed a relevant TODO.
2011-09-22 04:18:13 +03:00
Filippos Karapetis
3774c38db5 SCI: Added two workarounds for script bug #3389579 2011-08-25 01:49:26 +03:00
Willem Jan Palenstijn
3e38e6e221 SCI: Restore deleted LSL6 workaround for crash on loading
This was probably accidentally removed in
194081e7ae. The TODO/CHECKME on it still
applies. Reported in bug #3366329.
2011-07-13 22:43:21 +02:00
Filippos Karapetis
168ba00ea3 SCI: Fixed script bug #3292327 - "SCI: HOYLE4: Cribbage bug" 2011-06-28 12:56:09 +03:00
Max Horn
88913c0139 ALL: Remove trailing whitespaces
This tries to make our code a bit more compliant with our code formatting
conventions. For future use, this is the command I used:
  git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
2011-06-20 00:59:48 +02:00
md5
ece449298d SCI: Fixed script bug #3313962 - "ECOQUEST2 Spanish: Crash near beginning" 2011-06-11 14:34:47 +03:00
Max Horn
11bd6da595 SCI: Switch some char* to Common::String& 2011-06-03 16:16:38 +02:00
md5
28b7cf71a9 SCI: Added a workaround for bug #3308087 - "SCI: SQ1VGA - Engine Abort Upon Loading Ulence Flats Save" 2011-05-27 02:47:48 +03:00
md5
a3c6439a1a SCI: Added workarounds for bug #3292251, instead of patching the script
This fixes bug #3295853
2011-05-13 00:10:44 +03:00
strangerke
69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
md5
14865cbf9c SCI: Fixed script bug #3292334 - "HOYLE4: Gin Rummy bug" 2011-04-26 19:08:02 +03:00
md5
1ba3d462d2 SCI: Fixed 2 script bugs in Hoyle 4 - hearts
This fixes bug #3292333 - "HOYLE4: Hearts bug"
2011-04-26 13:03:04 +03:00
md5
f752b1b2fc SCI: Fixed several uninitialized variable script bugs in Hoyle 4 Bridge
This fixes bug #3292332, along with other related issues
2011-04-26 12:56:11 +03:00
md5
b4051db142 SCI: Extended the script workaround for the sign reading script (bugs #3272735, #3275413) 2011-04-05 10:23:51 +03:00
md5
f4905eafd1 SCI: Added workaround for script bug #3272735 - "SCI: QFG2: Crash when typing 'read sign'" 2011-04-04 09:59:20 +03:00
md5
407b9c9b2e SCI: Added a workaround for script bug #3268076 - "MOTHERGOOSE: Crash after finishing the game" 2011-04-03 15:19:19 +03:00
Matthew Hoops
5bc5e95e12 SCI: Add workaround for a GK1 pointer comparison 2011-03-29 13:48:07 -04:00
md5
1f5c3a6967 SCI: Extended a workaround for KQ7 to apply in all rooms 2011-03-25 07:42:27 +02:00
md5
fa10ee66e4 SCI: Added proper fix for bug #3048054 - "LONGBOW: crash when opening hand code"
This was caused by a buggy script, most probably the result of an
incorrect copy/paste while processing the original script. Fixed with a
script patch.
2011-03-12 23:48:56 +02:00
Max Horn
2cbefc8bb5 SCI: Constify some code 2011-03-07 23:21:35 +01:00
md5
194081e7ae SCI: Removed several workarounds which are no longer needed, after the changes regarding hunk pointers in r0d555c4 2011-02-28 22:32:41 +02:00
Lars Skovlund
baa9cbf45c SCI: Add workaround for PQ:SWAT.
This is a bug in the SCI32 class library, and there are similar workarounds
for a number of SCI32 games.
2011-02-28 21:20:54 +01:00
md5
0d555c497d SCI: Moved hunk pointer handling to the GC, and removed some related workarounds
SCI scripts can contain stale pointers, which are used later on. We now delete
the contents of hunk entries without invalidating the relevant pointers and let
the GC clear the references. Many thanks to waltervn and wjp for all their work
and help on this.
2011-02-28 15:56:03 +02:00
md5
d05fb0cba6 SCI: Some spacing fixes and typos 2011-02-19 21:31:30 +02:00
md5
4e88d75eb6 SCI: Refactored the reg_t related operations and comparisons
This refactoring reduces a lot of code duplication, allows for better control,
makes the code more readable and allows us to remove a lot of now unneeded
workarounds
2011-02-19 20:22:43 +02:00
Matthew Hoops
e19d6a2462 SCI: Add workaround for uninitialized read in KQ5 FM Towns
Thanks to alexbevi
2011-02-16 14:24:39 -05:00
Matthew Hoops
758e495872 SCI: Add support for the KQ5 FM Towns resource format
Thanks to alexbevi for providing details on the format
2011-02-16 14:24:38 -05:00
Filippos Karapetis
745c04194a SCI: Added a workaround for MUMG Deluxe
svn-id: r55873
2011-02-10 16:49:46 +00:00
Matthew Hoops
e1bdfe16e3 SCI: Make Hoyle4 workarounds without names so they work in the Mac version (that has no class names)
svn-id: r55711
2011-02-01 21:15:26 +00:00
Filippos Karapetis
bb3fd747d4 SCI: Fixed bug #3155550 - "SQ4 Russian: Script error in Scate-o-rama"
svn-id: r55218
2011-01-12 23:53:14 +00:00
Filippos Karapetis
c215d85c33 SCI: Added a workaround for script bug #3156472 - "King's Quest 5 cdrom version crash on escape"
svn-id: r55217
2011-01-12 23:33:30 +00:00
Filippos Karapetis
fc83afc5f2 SCI2.1: Added/documented some functionality used by Shivers 1
- Added kFileIO subop 17 (create save slot)
- Added information about a (probably debug) kernel function used in a puzzle, kCelInfo
- Added some information on two kSave subops
- Added 2 workarounds for uninitialized variables

svn-id: r55158
2011-01-08 10:23:27 +00:00
Filippos Karapetis
e48b07e3bd SCI: Added workaround for script bug #3148418 - "QFG2: Script Error On last screen"
svn-id: r55075
2010-12-31 11:32:19 +00:00
Filippos Karapetis
3a14a7760e SCI: Fixed bug #3092115 - "ECOQUEST2: Initial text not cleared during ecorder intro"
svn-id: r54984
2010-12-21 15:31:59 +00:00
Filippos Karapetis
b837366871 SCI: Added an uninitialized read script workaround for QFG1VGA
svn-id: r54663
2010-11-30 00:27:36 +00:00