thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
43096 commits 35 branches 0 tags 1.4 GiB
Commit graph

53 commits

Author SHA1 Message Date
Filippos Karapetis
26dfb6affa SCI: Fixed bug #3041153 - "SCI Fanmade Games: Message window glitch" 
The left window dimension adjustment (rev #48772) has been moved from
GfxPorts::setOrigin() into GfxPorts::addWindow(), as the updated dimension is
later used when filling the contents of the window (apparent in some fan made
games)

svn-id: r54976
 2010-12-20 15:30:31 +00:00
Martin Kiewitz
eefa151d70 SCI: saving/restoring script created windows now 
fixes "GfxPorts::kernelSetActive" error
based on code by [md5]

svn-id: r54012
 2010-11-01 16:09:33 +00:00
Torbjörn Andersson
c91a07229a JANITORIAL: Removed most punctuation at end of warning() and error() 
Our warning() and error() functions always add an exclamation mark
to the end of the message anyway.

svn-id: r52791
 2010-09-18 10:55:16 +00:00
Martin Kiewitz
7b8add291e SCI: multiple changes for mother goose vga 
which is sci1 and sci1.1
fixes bug #3051145
- separating this mother goose from ega and sci2.1
- adding workaround when restoring saved games in these games, games try to calculate restored savedgameid instead of looking it up, we patch this code out and also set the global to the current savedgameid
- adding workaround for scripts checking savedgameid to be below 13 (our savedgameids begin at 100 now)
- changing official range for savedgameids from 1000->1999 to 100->199, otherwise mother goose would have required much larger patches and this range should be fine even if we replace savedgame dialogs later

svn-id: r52301
 2010-08-23 16:33:19 +00:00
Filippos Karapetis
dd1708a1f1 Reverting r52224, as it was incorrect - fanmade games use the same interpreter as normal ones, so this doesn't make sense. Added a FIXME with a description about the graphics glitch in fanmade games 
svn-id: r52225
 2010-08-20 15:17:19 +00:00
Filippos Karapetis
273a9eb036 SCI: Fixed bug #3041153 - "SCI Fanmade Games: Message window glitch" 
svn-id: r52224
 2010-08-20 12:24:48 +00:00
Martin Kiewitz
f8697e20b5 SCI: now reusing window ids on kNewWindow 
sq4cd recreates the inventory window several times, but also reuses old window ids, causing kernelSetActive errors. fixes bug #3044757

svn-id: r52079
 2010-08-14 08:03:32 +00:00
Martin Kiewitz
512bf22af6 SCI: adding workaround for camelot during ending 
fixes bug #3044734
also fixing heap corruption during the ending

svn-id: r52077
 2010-08-14 06:05:54 +00:00
Martin Kiewitz
6181241f57 SCI: extending life of port for sq4 gum wrapper 
fixes bug #3044507

svn-id: r52068
 2010-08-13 18:25:16 +00:00
Martin Kiewitz
a06dcea2e5 SCI: kDisposeWindow changes 
kDisposeWindow doesn't free windows immediately anymore. We free them after some calls to kSetPort, so the handle will be valid for a short time. Fixes sq4cd and hoyle 4 (commented out patching of script for hoyle 4)

svn-id: r51932
 2010-08-08 18:26:40 +00:00
Martin Kiewitz
753c431937 SCI: adding script patching 
including a patch for hoyle 4 and commenting out the workaround code inside kDisposeWindow

svn-id: r51795
 2010-08-06 18:54:58 +00:00
Martin Kiewitz
c71f1f1612 SCI: actually enable hoyle 4 workaround 
and adding additional comment

svn-id: r51754
 2010-08-05 07:54:33 +00:00
Martin Kiewitz
1b69257654 SCI: changing hoyle 4 workaround 
fixing hoyle 4 detection entry (not a demo)
adding direct selector fix, maybe we should replace this later with a script patch
adding detailed comment about the issue

svn-id: r51753
 2010-08-05 07:49:19 +00:00
Filippos Karapetis
624107319e SCI: Fixed an off-by-one error in GfxPorts::getPortById() and moved the error checking code outside the function. Also fixed script bug #3039305 - "HOYLE4: segfault" 
svn-id: r51733
 2010-08-04 12:41:00 +00:00
Martin Kiewitz
2e11c1cf96 SCI: reset ports when restoring 
fixes qfg3/fairy tales restoring (bug #3035626)
also fixes ScummVM menu restoring while a window is shown (e.g. sq5)

svn-id: r51712
 2010-08-03 19:43:16 +00:00
Martin Kiewitz
512fec56c7 SCI: adding offTop = 0 for mother goose sci1.1 
fixes graphics in that game

svn-id: r51643
 2010-08-02 18:04:23 +00:00
Martin Kiewitz
97b1cd34cf SCI: sci1.1 priority bands now changing in kDrawPic 
fixes qfg3: right guard on top of the palace having wrong priority
fixes sq5 and all sorts of sci1.1 games: when loading wrong priority for some actors that fixed itself after one frame

svn-id: r51397
 2010-07-27 23:20:43 +00:00
Filippos Karapetis
9da4c3f883 SCI: Some cosmetic changes to the warning thrown when fixing invalid windows 
svn-id: r51306
 2010-07-26 09:18:04 +00:00
Martin Kiewitz
32c81fa918 SCI: fixing kNewWindow (SCI1.1) 
check differently for null restoreRect, fixes pq3 some windows not getting fully removed
calling showBits on actual dims and not on restoreRect, fixes lb2 about window issues (and possible qfg1vga window issues as well)

svn-id: r51204
 2010-07-23 12:37:58 +00:00
Martin Kiewitz
e857cc623e SCI: added comment - lsl5 also has too large windows 
svn-id: r50450
 2010-06-28 16:35:20 +00:00
Filippos Karapetis
e6a9a9da82 Silenced a false positive in MSVC about a potentially uninitialized variable 
svn-id: r50392
 2010-06-27 20:22:09 +00:00
Max Horn
6ee82a2027 SCI: Introduce SciGameId enum 
svn-id: r50273
 2010-06-25 16:16:29 +00:00
Martin Kiewitz
72ee20bc4d SCI: cnick-laurabow & cnick-kq are called with -Nw 0 0... 
svn-id: r50187
 2010-06-23 17:05:54 +00:00
Martin Kiewitz
d8968ee5b9 SCI: reversing r50168, demo is using the same offTop as well (demo.bat) 
svn-id: r50169
 2010-06-22 21:05:34 +00:00
Martin Kiewitz
93b2336aa2 SCI: demo of fairy tales uses regular offTop 
svn-id: r50168
 2010-06-22 21:01:34 +00:00
Martin Kiewitz
a836f965f8 SCI: set offTop to 26 for mixed up fairy tales to fix all sorts of non-fully-removed windows 
svn-id: r50166
 2010-06-22 20:40:41 +00:00
Matthew Hoops
0ab7a16e45 Fix the Hoyle 4 (Hoyle Classic) demo's top offset. It currently errors out later from lacking a selector (static selector problem). 
svn-id: r50118
 2010-06-21 19:07:41 +00:00
Filippos Karapetis
db70d66e4a Strict mode: Changed several warnings due to logic bugs into errors. If an error pops up from these ones, please add the game where it occurred and the steps to reproduce the error before turning it into a warning 
svn-id: r49973
 2010-06-17 23:50:28 +00:00
Max Horn
359be0c066 SCI: Change SciEngine's 'char *getGameID()' to 'Common::String getGameId()' 
svn-id: r49968
 2010-06-17 23:14:34 +00:00
Martin Kiewitz
27741ee970 SCI: dont subtract offTop on wmgrPort when using old gfx functions - fixes about window in pq2 
svn-id: r49947
 2010-06-17 19:42:34 +00:00
Martin Kiewitz
ba2de6dfa4 SCI: putting SciGui::init into SciEngine, removing it from SciGui(32) 
svn-id: r49854
 2010-06-15 13:34:40 +00:00
Martin Kiewitz
3269e5cc4c SCI: adjust priority bottom, if its 200 to avoid possible out of bounds (sierra actually does the same) 
svn-id: r49592
 2010-06-11 09:17:11 +00:00
Filippos Karapetis
c874ff15a8 Cleaned up the game ID code: 
- The game ID is now obtained from ScummVM ID directly, not by converting Sierra's internal ID
- Moved the code which reads the internal Sierra ID inside the resource manager
- Moved the code which converts the internal Sierra ID to ScummVM's IDs together with the rest of the detection code

svn-id: r49152
 2010-05-23 10:28:03 +00:00
Martin Kiewitz
ae4da9debe SCI: setting port _menuPort, fixing crash on setFont() 
svn-id: r49043
 2010-05-15 15:59:46 +00:00
Martin Kiewitz
19af89a902 SCI: removed _mainPort (was unused, is unused) 
svn-id: r49042
 2010-05-15 15:45:05 +00:00
Martin Kiewitz
59a255226f SCI: SCI_SCREEN_MASK_* now GFX_SCREEN_MASK_*, using enum - added new enum GFX_SCREEN_UPSCALED_* 
svn-id: r49039
 2010-05-15 08:57:13 +00:00
Martin Kiewitz
c083ce2879 SCI: fix window, when its too large for screen (fixes sq3 crash at ending, actually caused by script bug) 
svn-id: r49028
 2010-05-13 22:04:53 +00:00
Martin Kiewitz
38c661bfac SCI: fix regression of r49026 - line between titlebar and actual window was overdrawn 
svn-id: r49027
 2010-05-13 21:29:32 +00:00
Martin Kiewitz
a5f59ccdae SCI: remove hack code for shadows and implement them properly (shadow is actually part of the window, not added onto the window) - fixes especially lsl5 
svn-id: r49026
 2010-05-13 21:14:37 +00:00
Martin Kiewitz
070b2e14fe SCI: don't adjust new windows to _wmgrPort for oldGfxFunctions() games (till kq4 .502), fixes all window positions for those especially sq3old speech bubble windows 
svn-id: r49025
 2010-05-13 20:19:54 +00:00
Martin Kiewitz
579a19fbc4 SCI: fix code that was commented out (wasn't meant to get commited that way) during cleanup r47745 
svn-id: r49015
 2010-05-12 19:46:24 +00:00
Martin Kiewitz
78e85ce053 SCI: fixing regression from r48771 - sierra used != before SCI1LATE and !(&) later - fixes broken windows in sq1 
svn-id: r48807
 2010-04-26 15:30:32 +00:00
Martin Kiewitz
3005fffe78 SCI: draw a black line between titlebar and actual window content for SCI0, also replaced hardcoded white value (255) with screen specific value 
svn-id: r48798
 2010-04-25 19:49:10 +00:00
Martin Kiewitz
1243217547 SCI: added additional comment for setOrigin() commit (from waltervn), after doing some test with sierra interpreter 
svn-id: r48775
 2010-04-22 18:12:25 +00:00
Martin Kiewitz
4fbea9d02d SCI: make setOrigin() for ports behave like in sierra sci, fixes qfg1ega character screen issues ("moving" controls), fixes jones/vga 1 pixel-off windows 
svn-id: r48772
 2010-04-22 17:41:04 +00:00
Martin Kiewitz
e25651a467 SCI: SCI1LATE+ checks for STYLE_USER, versions before check for STYLE_USER|STYLE_TRANSPARENT 
svn-id: r48771
 2010-04-22 16:55:46 +00:00
Martin Kiewitz
2242ee33ac SCI: get color white instead of hardcoded 255 inside openPort(), fixes not working inverting of button controls on qfg1ega character stats screen 
svn-id: r48755
 2010-04-20 19:37:58 +00:00
Martin Kiewitz
71fb77a5aa SCI: priority band specific stuff now gets called directly w/o SciGui 
svn-id: r47916
 2010-02-05 22:20:46 +00:00
Martin Kiewitz
f3ea96d168 SCI: GfxCoordAdjuster class added, local2Global and global2Local use that class directly, kGraph / RedrawBox is now using GfxPaint16 directly 
svn-id: r47908
 2010-02-05 18:56:13 +00:00
Matthew Hoops
d1bc12300c mothergoose SCI1 starts at the top of the screen, so set offTop to 0 for that version. 
svn-id: r47786
 2010-01-31 23:53:25 +00:00