thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
scummvm/engines
History
lolbot-iichan 13dbfbd8d7 WINTERMUTE: Fix slider bugs in several games 
There is a bug introduced in WME Lite.

Testcase:
1. Download https://github.com/lolbot-iichan/wme_testsuite/tree/master/slider_test/packages
2. Download https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/wmelite/wmelite_10_win.zip
3a. Run game.exe -> Slider moves with the mouse while it is pressed and
released when mouse is released
3b. Run wmelite.exe -> Slider is never released
3c. Run ScummVM -> Slider is never released

Related bugs:
https://bugs.scummvm.org/ticket/6567
https://bugs.scummvm.org/ticket/9861

Reason: slider is a button object that changes it's X until "LeftRelease" event is revieved and breaks the endless loop.
Sample code: https://github.com/lolbot-iichan/wme_testsuite/blob/master/slider_test/data/interface/system/speechvolume.script
However, WME Lite does not send "LeftRelease" events to any objects, if Game object can handle such event, even is game is frozen and UI is shown.

Original code: https://github.com/lolbot-iichan/Wintermute-Engine/blob/master/src/engine_core/wme_ad/AdGame.cpp#L2218
Changed in WME Lite: https://github.com/lolbot-iichan/wmelite/blob/master/src/AdGame.cpp#L2120

This behaviour was introduced in SVN period of wmelite, I believe it was
made on purpose for handling some iOS scenarios at commit #37 mentioned
on page https://code.google.com/archive/p/wmelite/source/default/commits

My proposal is to mark iOS apps as WME_LITE and fill exact WME_1_X_X/WME_LITE versions for all known
games. WME_1_X_X can be seen by right-clicking on main executable and seems to be non-empty for almost all existing WME games.
2019-07-02 08:00:30 +03:00
..
access ACCESS: AMAZON: Fix crash due to Common::Language change 2019-03-03 21:52:57 -08:00
adl Revert "ADL: Fix MSVC warnings" 2019-05-27 20:18:28 +02:00
agi AGI: Fix Several GCC Compiler Warnings 2019-05-08 00:42:03 +01:00
agos AGOS: Fix Accolade MIDI Driver Compilation Breakage 2019-06-03 19:35:48 +01:00
avalanche ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
bbvs
bladerunner BLADERUNNER: Rat AI bug fixes 2019-07-01 21:03:03 +03:00
cge ENGINES: Add unknown game variants to the game detector results 2018-05-10 09:04:23 +02:00
cge2 CGE2: Allow Triggering of Carpet Workaround from Debug Console. 2018-10-09 18:10:40 +01:00
chewy ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
cine ALL: revert accidental commits 2019-06-21 14:19:42 +02:00
composer COMPOSER: Always check resources before loading them 2019-03-10 04:51:39 +02:00
cruise ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
cryo CRYO: Fix MSVC warnings 2019-05-27 14:53:38 +03:00
cryomni3d JANITORIAL/CRYOMNI3D: Fix warnings in MSVC 2019-06-30 16:46:32 +02:00
director GRAPHICS: MACGUI: Make use of Common::String::format (#1454) 2018-12-23 15:57:20 +02:00
dm DM: Fix class member naming, and silence some MSVC warnings 2018-12-23 20:40:21 +02:00
draci ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
drascula DRASCULA: Fix loading game from launcher 2019-05-13 22:56:57 +01:00
dreamweb ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
fullpipe FULLPIPE: Silence a false positive warning in MSVC 2018-12-23 20:41:33 +02:00
glk GLK: ALAN2: Fix loading memory for Big Endian 2019-06-27 18:55:25 -07:00
gnap COMMON: Replace NEResourceType and PEResourceType with a shared enum 2019-05-01 23:52:56 +03:00
gob GOB: Correct Crousibat Detection Entry to European Portuguese. 2018-11-03 17:14:18 +00:00
groovie IMAGE: Allow setting the output pixel format to the JPEG decoder 2019-04-28 07:59:14 +02:00
hopkins ENGINES: Use an uppercase C for the metaengine copyright strings 2018-12-10 18:39:26 +01:00
hugo
illusions ILLUSIONS: Fix MSVC warnings 2019-05-27 14:53:38 +03:00
kyra ALL: Fix -Wnewline-eof warnings 2019-06-22 17:27:07 +01:00
lab ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
lastexpress ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
lilliput ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
lure ENGINES: Add GUIErrorMessageFormat to replace duplicated functions (#1455) 2018-12-19 08:31:26 +02:00
macventure MACVENTURE: Fix MSVC warnings 2019-05-27 14:53:39 +03:00
made MADE: Remove leftover code. This lets run gracefully with -p parameter 2019-06-10 12:55:08 +02:00
mads ENGINES: Use an uppercase C for the metaengine copyright strings 2018-12-10 18:39:26 +01:00
mohawk MOHAWK: Fix MSVC warnings 2019-05-27 14:53:40 +03:00
mortevielle ENGINES: Add GUIErrorMessageFormat to replace duplicated functions (#1455) 2018-12-19 08:31:26 +02:00
mutationofjb MUTATIONOFJB: Fix warning 2019-04-11 21:21:21 +01:00
neverhood ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
parallaction PARALLACTION: Replace use of strdup with Common::String & malloc 2018-08-18 16:30:05 +02:00
pegasus PEGASUS: Fix MSVC warnings 2019-05-27 14:53:41 +03:00
pink PINK: removed usage of global variable 2019-05-08 12:01:22 +03:00
plumbers ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
prince ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
queen QUEEN: Fix GCC Compiler Warnings 2019-05-07 23:16:50 +01:00
saga SAGA: Fix potential crash when talking to Sist (bug #10365) 2019-02-03 23:33:59 +02:00
sci SCI32: Fix QFG4 Look-Dungeon Message 2019-07-02 01:10:42 +03:00
scumm SCUMM: Fix MSVC warnings 2019-05-27 14:53:42 +03:00
sherlock SHERLOCK: RT: Fix Spanish crash talking to lady in Tailor shop 2019-05-21 18:30:10 -07:00
sky WINCE: Fix compilation 2019-04-15 08:06:39 +03:00
sludge SLUDGE: implement random built-in 2019-06-18 08:28:38 +03:00
startrek STARTREK: Rename the different showText() functions for disambiguation 2019-06-11 01:28:12 +03:00
supernova SUPERNOVA: Adds text reader to view text files 2019-05-28 02:24:43 +02:00
sword1 ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
sword2 ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
sword25 Sword25: image trace on quick cursor changes fix 2019-04-09 21:14:23 +03:00
teenagent
testbed TESTBED: Correctly reset the number of skipped tests 2019-07-01 22:49:42 +01:00
tinsel TINSEL: Fix displayed saved game month off by one 2018-08-07 18:38:40 -07:00
titanic TITANIC: Change add float suffixes to float assignments 2019-05-27 14:53:45 +03:00
toltecs ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
tony ENGINES: Add GUIErrorMessageFormat to replace duplicated functions (#1455) 2018-12-19 08:31:26 +02:00
toon TOON: Add detection entry for English re-release 2019-03-21 21:58:36 +01:00
touche ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
tsage TSAGE: Don't allow saving in Ringworld copy protection dialog 2018-08-21 19:24:25 -07:00
tucker TUCKER: Added support for Russian fan translation 2018-12-30 19:52:27 +01:00
voyeur ENGINES: Normalize the getName() result of metaengines 2018-12-10 06:47:27 +01:00
wage ENGINES: Add missing dependencies for several engines 2018-06-30 00:22:34 +02:00
wintermute WINTERMUTE: Fix slider bugs in several games 2019-07-02 08:00:30 +03:00
xeen XEEN: Fix mistakes in xeen.ccs datafile, bump up version number 2019-06-09 14:35:15 -07:00
zvision ZVISION: Move code to determine amplification to its own function 2019-02-10 16:32:02 +02:00
advancedDetector.cpp COMMON: Include hidden files in directory listings by default 2019-01-30 06:48:32 +01:00
advancedDetector.h ENGINES: Cleanup DetectedGame initialization in the AD 2018-05-10 09:04:23 +02:00
dialogs.cpp
dialogs.h
engine.cpp ENGINES: Use new logo for splash screen 2019-03-30 23:25:01 +00:00
engine.h ENGINES: Add GUIErrorMessageFormat to replace duplicated functions (#1455) 2018-12-19 08:31:26 +02:00
game.cpp GUI: Better integration for the unknown game dialog when adding games 2019-05-12 11:44:51 +03:00
game.h GUI: Better integration for the unknown game dialog when adding games 2019-05-12 11:44:51 +03:00
logo_data.h ENGINES: Use new logo for splash screen 2019-03-30 23:25:01 +00:00
metaengine.h ENGINES: Merge GameDescriptor and DetectedGame 2018-05-10 09:04:23 +02:00
module.mk GUI: Move UnknownGameDialog to gui 2018-05-28 20:55:00 +01:00
obsolete.cpp ENGINES: Remove usage of C++11 extended initializer lists 2018-05-10 09:26:26 +02:00
obsolete.h ENGINES: Change MetaEngine::findGame to return a plain game descriptor 2018-05-10 09:04:23 +02:00
savestate.cpp GRAPHICS: Add playtime in milliseconds to SaveStateDescriptor 2018-07-21 13:15:14 +02:00
savestate.h GRAPHICS: Add playtime in milliseconds to SaveStateDescriptor 2018-07-21 13:15:14 +02:00
util.h